Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not require namespaces when parsing errors about cluster scoped resources #5764

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Mar 28, 2024

What this PR does / why we need it:

This PR will fix an error when user does not have the admission webhook enabled and applies a configuration which has a cluster scoped resource being the offender, e.g. KongClusterPlugin with incorrect schema which up until now yields:

2024-02-04T18:19:55Z    error    Entity tags missing fields    {"name": "prometheus", "error": "no namespace"}

Since KongClusterPlugin is cluster scoped it does not have a namespace. This PR fixes that.

Fixes: #5555

@pmalek pmalek added this to the KIC v3.2.x milestone Mar 28, 2024
@pmalek pmalek self-assigned this Mar 28, 2024
@pmalek pmalek requested a review from a team as a code owner March 28, 2024 10:57
@pmalek pmalek enabled auto-merge (squash) March 28, 2024 11:09
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.4%. Comparing base (713765d) to head (e63c663).

Files Patch % Lines
...al/dataplane/sendconfig/inmemory_error_handling.go 60.0% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5764   +/-   ##
=====================================
  Coverage   73.4%   73.4%           
=====================================
  Files        175     175           
  Lines      18147   18151    +4     
=====================================
+ Hits       13321   13335   +14     
+ Misses      3856    3844   -12     
- Partials     970     972    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek merged commit a1bfdb3 into main Mar 28, 2024
48 checks passed
@pmalek pmalek deleted the do-not-require-namespaces-from-cluster-scope-resources-when-parsing-errors branch March 28, 2024 11:40
@pmalek pmalek mentioned this pull request Mar 28, 2024
29 tasks
pmalek added a commit that referenced this pull request Apr 2, 2024
pmalek added a commit that referenced this pull request Apr 3, 2024
@pmalek pmalek mentioned this pull request Apr 3, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KongClusterPlugin with invalid schema will cause invalid errors without admission webhook enabled
2 participants