Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release/3.1.x] fix: do not require namespaces when parsing errors about cluster scoped resources (#5764) #5789

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Apr 2, 2024

What this PR does / why we need it:

Backports #5764 to release/3.1.x

@pmalek pmalek added this to the KIC v3.1.x milestone Apr 2, 2024
@pmalek pmalek self-assigned this Apr 2, 2024
@pmalek pmalek marked this pull request as ready for review April 2, 2024 12:31
@pmalek pmalek requested a review from a team as a code owner April 2, 2024 12:31
@pmalek pmalek enabled auto-merge (squash) April 2, 2024 12:34
@pmalek pmalek changed the title fix: do not require namespaces when parsing errors about cluster scoped resources (#5764) [Backport release/3.1.x] fix: do not require namespaces when parsing errors about cluster scoped resources (#5764) Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/3.1.x@a69511f). Click here to learn what that means.

Files Patch % Lines
...al/dataplane/sendconfig/inmemory_error_handling.go 60.0% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/3.1.x   #5789   +/-   ##
===============================================
  Coverage                 ?   71.7%           
===============================================
  Files                    ?     176           
  Lines                    ?   18304           
  Branches                 ?       0           
===============================================
  Hits                     ?   13139           
  Misses                   ?    4200           
  Partials                 ?     965           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek merged commit cb6e7ab into release/3.1.x Apr 3, 2024
35 checks passed
@pmalek pmalek deleted the backport-3.1.x-pr-5764 branch April 3, 2024 06:52
@pmalek pmalek mentioned this pull request Apr 3, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants