Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration): expose KUBE_VERSION #1022

Merged
merged 1 commit into from Jan 29, 2021
Merged

Conversation

mflendrich
Copy link
Member

Makes it possible to specify the version of Kubernetes running KIC's integration test.

The choice is limited to available tags of the docker/io/kindest/node docker registry (which doesn't cover all releases at this moment). Asked kind maintainers (kubernetes-sigs/kind#197 (comment)) to increase coverage (specifically: start providing images for pre-release k8s builds as well)

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #1022 (60c67cb) into main (91585dd) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
- Coverage   49.65%   49.56%   -0.10%     
==========================================
  Files          32       32              
  Lines        3198     3198              
==========================================
- Hits         1588     1585       -3     
- Misses       1481     1483       +2     
- Partials      129      130       +1     
Impacted Files Coverage Δ
internal/ingress/controller/parser/parser.go 83.92% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91585dd...60c67cb. Read the comment docs.

@mflendrich mflendrich force-pushed the test/e2e-k8s-versions branch 2 times, most recently from c124b74 to 7f0e03d Compare January 28, 2021 21:49
Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK what the heck codecov's problem is, but LGTM

Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Codecov for some reason seems to have only just fully evaluated parser.go as an effect of this test, which caused it to trigger some new differences with it's base:

https://app.codecov.io/gh/Kong/kubernetes-ingress-controller/compare/1022/changes

I feel like this could have been a bug in previous code coverage not evaluating this on Codecov's end which may be covered up once this merges.

Seems reasonably innocuous but if we wanted to I suppose we could report the bug to codecov and see what they say.

@mflendrich mflendrich merged commit f69ea6f into main Jan 29, 2021
@mflendrich mflendrich deleted the test/e2e-k8s-versions branch January 29, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants