Add TLS (HTTPS) section to gke.md #148
Closed
+58
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 26.26% 26.37% +0.11%
==========================================
Files 46 46
Lines 3591 3591
==========================================
+ Hits 943 947 +4
+ Misses 2534 2530 -4
Partials 114 114
Continue to review full report at Codecov.
|
|
Although it's arguably covered in the gke-letsencrypt steps, I'd recommend noting that the Ingress creation at the end is effectively step 4 of their instructions, and that steps 5 & 6 should be completed afterward. |
|
@rainest I added the timing of the Ingress creation |
|
ping @rainest |
coopr
reviewed
Oct 3, 2018
| @@ -216,13 +216,13 @@ spec: | |||
|
|
|||
| You need to set your API with HTTPS in order to expose your service securely. In this section, I will explain how to secure it with [Let’s Encrypt](https://letsencrypt.org/). | |||
|
|
|||
| 1. Register your domain | |||
| ##### 1. Register fyour domain | |||
rainest
approved these changes
Oct 3, 2018
|
@tamanyan Merged manually. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update gke.md in order to add the instruction of how to setup TLS (HTTPS) on GKE by using Let's Encrypt.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Nothing.
Special notes for your reviewer:
Nothing.