feat: add support for custom TLS certificate #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following options have been added to work with custom TLS certificates, SNI names and to ignore a self-signed certificate: - `--admin-tls-skip-verify`: to skip validation of a certificate, this shouldn't be used in a production environment. - `--admin-tls-server-name`: use this if the FQDN of Kong's Admin API doesn't match the SNI name in the certificate. - `--admin-ca-cert-file`: use this to specify a custom CA cert which is not part of the bundled CA certs.
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
+ Coverage 21.7% 21.85% +0.15%
==========================================
Files 24 24
Lines 2350 2375 +25
==========================================
+ Hits 510 519 +9
- Misses 1796 1812 +16
Partials 44 44
Continue to review full report at Codecov.
|
fffonion
approved these changes
Dec 20, 2018
fffonion
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following options have been added to work with custom TLS certificates,
SNI names and to ignore a self-signed certificate:
--admin-tls-skip-verify: to skip validation of a certificate, thisshouldn't be used in a production environment.
--admin-tls-server-name: use this if the FQDN of Kong's Admin APIdoesn't match the SNI name in the certificate.
--admin-ca-cert-file: use this to specify a custom CA cert which isnot part of the bundled CA certs.