Feat/kong 1.0 to next #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking Change --------------- Users wanting to benefit from projects like kube-lego can switch the ingress class back to nginx.
As go-kong was bumped up for Kong 1.0, it introduces a few breaking API changes.
fffonion
reviewed
Dec 20, 2018
fffonion
reviewed
Dec 20, 2018
| @@ -148,7 +148,7 @@ func (n *NGINXController) syncGlobalPlugins() error { | |||
| // plugins in Kong | |||
| currentGlobalPlugins := make(map[string]kong.Plugin) | |||
| for _, plugin := range plugins { | |||
| if isEmpty(plugin.RouteID) && isEmpty(plugin.ServiceID) && isEmpty(plugin.ConsumerID) { | |||
There was a problem hiding this comment.
is this and the following several changes needed because the api change in the upstream go-kong library?
There was a problem hiding this comment.
Yes, which was needed because Kong 1.0
fffonion
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support for Kong 1.0