fix: match listener names for routes #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
randmonkey
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
randmonkey
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
randmonkey
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
pmalek
reviewed
Dec 8, 2022
randmonkey
force-pushed
the
fix/match_listener_name
branch
from
167ef84
to
d3b8d3e
Compare
randmonkey
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
randmonkey
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
randmonkey
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
pmalek
reviewed
Dec 9, 2022
randmonkey
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
pmalek
added
the
area/gateway-api
pmalek
approved these changes
Dec 9, 2022
randmonkey
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
randmonkey
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Match listener names if routes specified
sectionNamein their parentRefs. If a route specifiessectionNamein its parentRef, and no listeners can match the name, the route is not accepted.Which issue this PR fixes:
fixes #3221
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR