tests: deploy knative addon only when necessary #3316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
added
area/knative
area/maintenance
pmalek
force-pushed
the
deploy-knative-addon-only-when-necessary
branch
2 times, most recently
from
f0e5d83
to
f35702c
Compare
pmalek
force-pushed
the
deploy-knative-addon-only-when-necessary
branch
from
f35702c
to
ef30742
Compare
|
This seems to be failing because we don't start controllers for which we don't have CRDs installed (feature) :) Closing. We can revisit this when we figure #3029 out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes it so that knative tests that require knative addon to be installed install it themselves, whenever needed. This makes all the other tests to run without knative addon, faster and it also makes the knative addon not install itself when running tests manually with
-run Test....flag.