-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Kong service name in multi-Service Events #3318
Conversation
1c96456
to
f2c58ef
Compare
f2c58ef
to
e0f4e21
Compare
75fde8d
to
e0f4e21
Compare
Codecov ReportBase: 73.9% // Head: 73.9% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3318 +/- ##
======================================
Coverage 73.9% 73.9%
======================================
Files 113 110 -3
Lines 13896 13265 -631
======================================
- Hits 10282 9816 -466
+ Misses 2963 2813 -150
+ Partials 651 636 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
1074a0c
to
1df34b3
Compare
Include the Kong service name when emitting Events related to multi-Service backend annotation inconsistency. This name indicates the parent route resource. Reviewing the route resource will show the other Services used by the problem rule.
1df34b3
to
9e43fed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 nit but you can disregard it and merge it
What this PR does / why we need it:
Adds Kong Service name to invalid multi-Service backend Events. This name indicates the route resource that requires the Service, and will in turn indicate the other Services that need matching annotations:
Cannot think of a non-awkward way to write that sentence though.
Which issue this PR fixes:
Fix #2566. Simpler than the original proposal, but satisfies the main goal of it.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR