Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse ttl to int in key auth credentials #3319

Merged
merged 3 commits into from
Jan 4, 2023

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Jan 4, 2023

What this PR does / why we need it:

parse ttl field of kong key-auth credentials to int type to fix error of invalid type when filling the ttl in secret to Kong credential.

Which issue this PR fixes:

fixes #2734
Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner January 4, 2023 03:48
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 74.1% // Head: 74.0% // Decreases project coverage by -0.0% ⚠️

Coverage data is based on head (45a1e67) compared to base (996bc14).
Patch coverage: 62.5% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3319     +/-   ##
=======================================
- Coverage   74.1%   74.0%   -0.1%     
=======================================
  Files        110     110             
  Lines      13255   13263      +8     
=======================================
- Hits        9826    9822      -4     
- Misses      2802    2809      +7     
- Partials     627     632      +5     
Impacted Files Coverage Δ
internal/dataplane/kongstate/kongstate.go 69.1% <62.5%> (-0.3%) ⬇️
...nternal/controllers/gateway/udproute_controller.go 73.6% <0.0%> (-2.8%) ⬇️
...nternal/controllers/gateway/tlsroute_controller.go 73.2% <0.0%> (-2.7%) ⬇️
internal/controllers/gateway/gateway_controller.go 66.8% <0.0%> (-1.2%) ⬇️
internal/controllers/gateway/gateway_utils.go 90.0% <0.0%> (-0.5%) ⬇️
internal/dataplane/parser/parser.go 89.7% <0.0%> (+0.6%) ⬆️
internal/dataplane/kongstate/service.go 67.3% <0.0%> (+1.2%) ⬆️
...nternal/controllers/gateway/tcproute_controller.go 75.6% <0.0%> (+2.6%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@randmonkey randmonkey requested a review from pmalek January 4, 2023 09:54
@pmalek pmalek added this to the KIC v2.8.1 milestone Jan 4, 2023
@pmalek pmalek merged commit 9a623ab into main Jan 4, 2023
@pmalek pmalek deleted the fix/credential_secrets_int branch January 4, 2023 10:34
@pmalek pmalek added the fix label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Int fields in credential Secrets incorrectly handled as strings
2 participants