-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dataplane propogate translation failures to controllers #3359
Conversation
Codecov ReportBase: 74.2% // Head: 74.1% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3359 +/- ##
=======================================
- Coverage 74.2% 74.1% -0.2%
=======================================
Files 110 110
Lines 13227 13312 +85
=======================================
+ Hits 9824 9871 +47
- Misses 2782 2815 +33
- Partials 621 626 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
e8ec225
to
a4f0f8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits :)
8ba9952
to
169cfdd
Compare
169cfdd
to
b7642bf
Compare
What this PR does / why we need it:
k8sobj.Set
to store configuration status including succeeded/failed and configured generationWhich issue this PR fixes:
fixes #3172
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR