Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dataplane propogate translation failures to controllers #3359

Merged
merged 4 commits into from
Jan 13, 2023

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Jan 11, 2023

What this PR does / why we need it:

  • modify k8sobj.Set to store configuration status including succeeded/failed and configured generation
  • publish events for translation failures
  • update controllers to log and requeue on translation failures

Which issue this PR fixes:

fixes #3172

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner January 11, 2023 10:26
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 74.2% // Head: 74.1% // Decreases project coverage by -0.1% ⚠️

Coverage data is based on head (e7be206) compared to base (faa1cff).
Patch coverage: 80.1% of modified lines in pull request are covered.

❗ Current head e7be206 differs from pull request most recent head b7642bf. Consider uploading reports for the commit b7642bf to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3359     +/-   ##
=======================================
- Coverage   74.2%   74.1%   -0.2%     
=======================================
  Files        110     110             
  Lines      13227   13312     +85     
=======================================
+ Hits        9824    9871     +47     
- Misses      2782    2815     +33     
- Partials     621     626      +5     
Impacted Files Coverage Δ
internal/controllers/knative/knative.go 48.0% <42.8%> (-0.6%) ⬇️
...trollers/configuration/zz_generated_controllers.go 35.6% <46.6%> (+0.1%) ⬆️
internal/util/kubernetes/object/set.go 91.1% <90.0%> (-8.9%) ⬇️
internal/dataplane/kong_client.go 84.6% <96.8%> (-0.4%) ⬇️
...ternal/controllers/gateway/httproute_controller.go 56.8% <100.0%> (+0.1%) ⬆️
...nternal/controllers/gateway/tcproute_controller.go 75.7% <100.0%> (+<0.1%) ⬆️
...nternal/controllers/gateway/tlsroute_controller.go 73.3% <100.0%> (+0.1%) ⬆️
...nternal/controllers/gateway/udproute_controller.go 76.4% <100.0%> (+<0.1%) ⬆️
internal/dataplane/parser/translators/ingress.go 92.3% <100.0%> (+0.6%) ⬆️
internal/dataplane/parser/parser.go 89.7% <0.0%> (-2.5%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/util/kubernetes/object/set.go Outdated Show resolved Hide resolved
@randmonkey randmonkey marked this pull request as draft January 11, 2023 17:00
@randmonkey randmonkey force-pushed the feat/parser_propogate_translation_errors branch from e8ec225 to a4f0f8f Compare January 13, 2023 06:16
@randmonkey randmonkey changed the title [WIP] feat: dataplane propogate translation failures to controllers feat: dataplane propogate translation failures to controllers Jan 13, 2023
@randmonkey randmonkey marked this pull request as ready for review January 13, 2023 06:55
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits :)

CHANGELOG.md Outdated Show resolved Hide resolved
internal/controllers/knative/knative.go Outdated Show resolved Hide resolved
internal/dataplane/parser/translators/ingress.go Outdated Show resolved Hide resolved
internal/util/kubernetes/object/set.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
@randmonkey randmonkey force-pushed the feat/parser_propogate_translation_errors branch from 8ba9952 to 169cfdd Compare January 13, 2023 14:11
@randmonkey randmonkey force-pushed the feat/parser_propogate_translation_errors branch from 169cfdd to b7642bf Compare January 13, 2023 14:24
@randmonkey randmonkey enabled auto-merge (squash) January 13, 2023 14:37
@randmonkey randmonkey merged commit 3db7010 into main Jan 13, 2023
@randmonkey randmonkey deleted the feat/parser_propogate_translation_errors branch January 13, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make configuration updates reporting compatible with error cases
3 participants