Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change existing resolvedRef condition to avoid duplicates #3386

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Jan 16, 2023

What this PR does / why we need it:

change exsiting resolvedRefs condition in HTTPRoute when there is already one in status to avoid multiple appearances of conditions with same type.

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner January 16, 2023 10:26
@pmalek pmalek added the area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API label Jan 16, 2023
@pmalek pmalek added this to the KIC v2.9.0 milestone Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 74.0% // Head: 74.1% // Increases project coverage by +0.0% 🎉

Coverage data is based on head (73e1c70) compared to base (2d565d2).
Patch coverage: 73.3% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3386   +/-   ##
=====================================
  Coverage   74.0%   74.1%           
=====================================
  Files        110     110           
  Lines      13284   13288    +4     
=====================================
+ Hits        9837    9850   +13     
+ Misses      2822    2815    -7     
+ Partials     625     623    -2     
Impacted Files Coverage Δ
...ternal/controllers/gateway/httproute_controller.go 57.8% <73.3%> (+1.1%) ⬆️
...nternal/controllers/gateway/tcproute_controller.go 73.0% <0.0%> (-2.7%) ⬇️
internal/dataplane/kongstate/service.go 66.0% <0.0%> (-1.3%) ⬇️
internal/dataplane/parser/parser.go 92.1% <0.0%> (+1.6%) ⬆️
...nternal/controllers/gateway/tlsroute_controller.go 75.8% <0.0%> (+2.6%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmalek pmalek changed the title fix: change existing resolvedRef condition to reduce dupelicate fix: change existing resolvedRef condition to avoid duplicates Jan 16, 2023
@pmalek pmalek merged commit 98fc6b4 into main Jan 16, 2023
@pmalek pmalek deleted the fix/duplicate_resolvedRef_condition branch January 16, 2023 11:42
@pmalek pmalek added the fix label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API fix size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants