Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): include gw discovery and konnect sync in reports #3588

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Feb 21, 2023

What this PR does / why we need it:

Adds feature-konnecy-sync={false,true}, feature-gateway-service-discovery={false, true} report values. Also removes unused code.

Which issue this PR fixes:

Closes #3460 and #3362.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo added area/feature New feature or request area/telemetry area/konnect Issues and PRs related to Konnect labels Feb 21, 2023
@czeslavo czeslavo self-assigned this Feb 21, 2023
@czeslavo czeslavo added this to the KIC v2.9.0 milestone Feb 21, 2023
@czeslavo czeslavo marked this pull request as ready for review February 21, 2023 13:05
@czeslavo czeslavo requested a review from a team as a code owner February 21, 2023 13:05
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 72.0% // Head: 71.9% // Decreases project coverage by -0.1% ⚠️

Coverage data is based on head (48783e2) compared to base (abdde8e).
Patch coverage: 37.5% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3588     +/-   ##
=======================================
- Coverage   72.0%   71.9%   -0.1%     
=======================================
  Files        130     130             
  Lines      15426   15438     +12     
=======================================
+ Hits       11109   11110      +1     
- Misses      3604    3612      +8     
- Partials     713     716      +3     
Impacted Files Coverage Δ
internal/manager/run.go 40.2% <0.0%> (-0.7%) ⬇️
internal/manager/telemetry/reports.go 0.0% <0.0%> (ø)
internal/manager/utils/kongconfig/root.go 50.0% <ø> (ø)
internal/manager/telemetry/manager.go 39.3% <64.2%> (+2.7%) ⬆️
...nternal/controllers/gateway/tlsroute_controller.go 71.4% <0.0%> (-2.1%) ⬇️
internal/dataplane/kongstate/service.go 66.0% <0.0%> (-1.3%) ⬇️
internal/dataplane/parser/parser.go 90.7% <0.0%> (-0.9%) ⬇️
...ternal/controllers/gateway/httproute_controller.go 71.6% <0.0%> (+1.8%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czeslavo czeslavo merged commit 8811f0b into main Feb 22, 2023
@czeslavo czeslavo deleted the telemetry-scd-konnect branch February 22, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request area/konnect Issues and PRs related to Konnect area/telemetry size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include the KIC-Konnect integration in telemetry
2 participants