Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway_discovery): allow gateway discovery only in dbless mode #3642

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Mar 2, 2023

What this PR does / why we need it:

Allow gateway discovery only in db-less mode

Which issue this PR fixes:

fixes #3401
Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner March 2, 2023 03:06
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 75.0% and project coverage change: +0.1 🎉

Comparison is base (afb93b3) 72.9% compared to head (ab3415c) 73.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3642     +/-   ##
=======================================
+ Coverage   72.9%   73.0%   +0.1%     
=======================================
  Files        131     131             
  Lines      15723   15735     +12     
=======================================
+ Hits       11469   11495     +26     
+ Misses      3494    3483     -11     
+ Partials     760     757      -3     
Impacted Files Coverage Δ
internal/manager/run.go 36.0% <25.0%> (-0.2%) ⬇️
internal/manager/config_validation.go 89.4% <100.0%> (+1.1%) ⬆️
internal/dataplane/parser/parser.go 89.1% <0.0%> (+0.6%) ⬆️
...nternal/controllers/gateway/tlsroute_controller.go 73.4% <0.0%> (+2.0%) ⬆️
...nternal/controllers/gateway/udproute_controller.go 73.7% <0.0%> (+2.1%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Mar 2, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
internal/manager/run.go Outdated Show resolved Hide resolved
@randmonkey randmonkey force-pushed the feat/disable_gateway_discovery_db_mode branch from b1fd772 to ab3415c Compare March 3, 2023 03:35
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 3, 2023
@randmonkey randmonkey merged commit f6a9e71 into main Mar 3, 2023
@randmonkey randmonkey deleted the feat/disable_gateway_discovery_db_mode branch March 3, 2023 08:30
CHANGELOG.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single controller deployments: limit functionality to dbless only
3 participants