fix: do not update secret when tls.secretName is empty #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
randmonkey
force-pushed
the
fix/skip_updating_tls_without_secrets
branch
from
b2873ef
to
d794f75
Compare
pmalek
reviewed
Mar 14, 2023
There was a problem hiding this comment.
The conformance tests for Gateway API are failling but I'm not sure if that's related: 🤔
httproute-observed-generation-bump.go:69:
Error Trace: /home/runner/go/pkg/mod/sigs.k8s.io/gateway-api@v0.6.1/conformance/tests/httproute-observed-generation-bump.go:69
Error: Received unexpected error:
Operation cannot be fulfilled on httproutes.gateway.networking.k8s.io "observed-generation-bump": the object has been modified; please apply your changes to the latest version and try again
Test: TestGatewayConformance/HTTPRouteObservedGenerationBump/observedGeneration_should_increment
Messages: error updating the HTTPRoute: Operation cannot be fulfilled on httproutes.gateway.networking.k8s.io "observed-generation-bump": the object has been modified; please apply your changes to the latest version and try again
--- FAIL: TestGatewayConformance/HTTPRouteObservedGenerationBump/observedGeneration_should_increment (0.02s)
I think this failure is not related to the PR itself, but worth creating an issue. |
pmalek
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When
ingress.Spec.TLSdoes not contain a secret, skip the updating of referred secrets because they are "Optional".Which issue this PR fixes:
fixes #3711
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR