Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): add discovered_gateways_count #3783

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Mar 21, 2023

What this PR does / why we need it:

Adds a discovered_gateways_count to a telemetry signal when the Gateway Discovery feature is turned on.

Which issue this PR fixes:

Solves #3779.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo self-assigned this Mar 21, 2023
@czeslavo czeslavo added this to the KIC v2.9.0 milestone Mar 21, 2023
@czeslavo czeslavo marked this pull request as ready for review March 21, 2023 12:42
@czeslavo czeslavo requested a review from a team as a code owner March 21, 2023 12:42
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 55.5% and project coverage change: +0.1 🎉

Comparison is base (98a3e4a) 56.7% compared to head (b5b3ac2) 56.8%.

❗ Current head b5b3ac2 differs from pull request most recent head 88dad8f. Consider uploading reports for the commit 88dad8f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3783     +/-   ##
=======================================
+ Coverage   56.7%   56.8%   +0.1%     
=======================================
  Files        133     134      +1     
  Lines      15871   15904     +33     
=======================================
+ Hits        9014    9049     +35     
  Misses      6238    6238             
+ Partials     619     617      -2     
Impacted Files Coverage Δ
internal/manager/telemetry/reports.go 0.0% <0.0%> (ø)
internal/manager/telemetry/manager.go 45.1% <37.5%> (+0.2%) ⬆️
...l/manager/telemetry/workflows/gateway_discovery.go 56.5% <56.5%> (ø)
internal/dataplane/clients_manager.go 96.8% <100.0%> (+0.1%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czeslavo czeslavo requested a review from pmalek March 21, 2023 13:46
@czeslavo czeslavo enabled auto-merge (squash) March 21, 2023 13:56
@czeslavo czeslavo merged commit 9efdffe into main Mar 21, 2023
@czeslavo czeslavo deleted the report-gateways-count branch March 21, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants