fix: fix paging in GetAdminAPIsForService #3846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
fix-paging-in-GetAdminAPIsForService
branch
from
c74dfdf
to
a2c08a4
Compare
czeslavo
reviewed
Apr 4, 2023
1 task
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
czeslavo
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As noticed by @seh in https://github.com/Kong/kubernetes-ingress-controller/pull/3509/files#r1149782341 the paging in
GetAdminAPIsForService()wasn't implemented 100% correct. Thecontinue, paging token wasn't set in the loop, causing the function to only return the head of the list.Which issue this PR fixes:
Fixes: #3815
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR