-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: assign Service, Route and Consumer entities stable IDs #3933
Conversation
fe72ef5
to
ee5f634
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3933 +/- ##
========================================
- Coverage 58.3% 21.9% -36.4%
========================================
Files 141 137 -4
Lines 16191 16058 -133
========================================
- Hits 9441 3524 -5917
- Misses 6107 12040 +5933
+ Partials 643 494 -149
... and 98 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ee5f634
to
30b8c97
Compare
30b8c97
to
72a6a90
Compare
What this PR does / why we need it:
Uses the
FillID
function fromgo-kong
to assign deterministic IDs forService
,Route
, andConsumer
Kong entities that are generated in the K8s -> Kong translation process.Which issue this PR fixes:
Closes #3906.
CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR