Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: assign Service, Route and Consumer entities stable IDs #3933

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Apr 25, 2023

What this PR does / why we need it:

Uses the FillID function from go-kong to assign deterministic IDs for Service, Route, and Consumer Kong entities that are generated in the K8s -> Kong translation process.

Which issue this PR fixes:

Closes #3906.

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo self-assigned this Apr 25, 2023
@czeslavo czeslavo added area/feature New feature or request area/konnect Issues and PRs related to Konnect labels Apr 25, 2023
@czeslavo czeslavo added this to the KIC v2.10.0 milestone Apr 25, 2023
@czeslavo czeslavo force-pushed the feat/assign-ids branch 2 times, most recently from fe72ef5 to ee5f634 Compare April 25, 2023 10:25
@czeslavo czeslavo marked this pull request as ready for review April 25, 2023 10:26
@czeslavo czeslavo requested a review from a team as a code owner April 25, 2023 10:26
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 42.1% and project coverage change: -36.4 ⚠️

Comparison is base (eb974e7) 58.3% compared to head (30b8c97) 21.9%.

❗ Current head 30b8c97 differs from pull request most recent head 72a6a90. Consider uploading reports for the commit 72a6a90 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3933      +/-   ##
========================================
- Coverage   58.3%   21.9%   -36.4%     
========================================
  Files        141     137       -4     
  Lines      16191   16058     -133     
========================================
- Hits        9441    3524    -5917     
- Misses      6107   12040    +5933     
+ Partials     643     494     -149     
Impacted Files Coverage Δ
internal/dataplane/kongstate/kongstate.go 21.5% <35.2%> (-47.8%) ⬇️
internal/dataplane/parser/parser.go 43.2% <100.0%> (-31.3%) ⬇️

... and 98 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pmalek
pmalek previously approved these changes Apr 25, 2023
@czeslavo czeslavo enabled auto-merge (squash) April 25, 2023 10:58
@czeslavo czeslavo merged commit 673c5d0 into main Apr 25, 2023
20 checks passed
@czeslavo czeslavo deleted the feat/assign-ids branch April 25, 2023 11:29
@mheap mheap linked an issue May 5, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request area/konnect Issues and PRs related to Konnect size/L
Projects
None yet
2 participants