-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expression router) Implement translator of ingresses #3935
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3935 +/- ##
=======================================
+ Coverage 58.7% 59.1% +0.4%
=======================================
Files 141 142 +1
Lines 16252 16521 +269
=======================================
+ Hits 9545 9772 +227
- Misses 6055 6085 +30
- Partials 652 664 +12
☔ View full report in Codecov by Sentry. |
6907cbe
to
564820e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of good work! 👍
My comments mainly gravitate around my thought that we should be careful when adding such a volume of brand new code by making sure that all of the pieces we add are properly unit tested + we have at least one integration test covering it works with Kong as expected in a sunny day scenario.
82fb33f
to
8f31796
Compare
I added several unit tests fro translating ingresses to expression routes. For integration tests, I added workflow |
6098cde
to
052ff70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
What this PR does / why we need it:
ExpressionRoutes
and flags in related structures (KongClient
,Parser
,KongState
,Route
) to process expression based routes in a different wayWhich issue this PR fixes:
fixes #3750
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR