chore(tests): fix assertion for TestGetEndpoints and refactor assertion for TestKnativeSelectSplit #3951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes assertion (and not properly configured test cases) for
TestGetEndpoints
to check not only the number of endpoints, but theirs content too. Moreover forTestKnativeSelectSplit
switches to assertion library instead of combination ofreflect.DeepEqual
&t.Errorf
.Which issue this PR fixes:
It's been spotted during working on #3916