Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up old, unused telemetry code #3964

Merged
merged 1 commit into from
May 8, 2023

Conversation

programmer04
Copy link
Member

What this PR does / why we need it:

Since merging PR #3552 in January the old, unused code related telemetry has been left in repository with annotation in PR's description

The existing code for anonymous reports was left as is in this PR but we can remove it if we decide that's the approach we'd like to take.

I think today it's obvious that using kubernetes-telemetry is the way of doing telemetry in KIC. Thus this PR removes old, unused code.

Special notes for your reviewer:

It's been spotted during work on #3916. As you can see e.g. dead code in internal/meshdetect/detector.go contains CoreV1 Endpoints.

@programmer04 programmer04 requested a review from a team as a code owner May 8, 2023 08:30
@programmer04 programmer04 added area/debt area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/telemetry and removed area/debt labels May 8, 2023
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@pmalek
Copy link
Member

pmalek commented May 8, 2023

👍 I can see some knative related integration tests failures 🤔 Seem unrelated but worth looking into (or creating an issue to investigate later on.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +9.0 🎉

Comparison is base (f70cdcd) 49.2% compared to head (90b22ae) 58.2%.

❗ Current head 90b22ae differs from pull request most recent head babfa67. Consider uploading reports for the commit babfa67 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3964     +/-   ##
=======================================
+ Coverage   49.2%   58.2%   +9.0%     
=======================================
  Files        139     139             
  Lines      16363   16115    -248     
=======================================
+ Hits        8051    9393   +1342     
+ Misses      7852    6091   -1761     
- Partials     460     631    +171     

see 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@randmonkey
Copy link
Contributor

+1 I can see some knative related integration tests failures thinking Seem unrelated but worth looking into (or creating an issue to investigate later on.

issue: #3965

@programmer04 programmer04 enabled auto-merge (squash) May 8, 2023 09:20
@programmer04 programmer04 self-assigned this May 8, 2023
@programmer04 programmer04 merged commit d3d893c into main May 8, 2023
21 checks passed
@programmer04 programmer04 deleted the rm-deprecated-telemetry branch May 8, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/telemetry size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants