Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: translate grpcroute to expression based routes #3988

Merged
merged 2 commits into from
May 15, 2023

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented May 11, 2023

What this PR does / why we need it:

translate GRPCRoute to expression based kong routes.

Which issue this PR fixes:

fixes #3752

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner May 11, 2023 03:57
@randmonkey randmonkey added area/feature New feature or request work in progress Work In Progress area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API labels May 11, 2023
@randmonkey randmonkey marked this pull request as draft May 11, 2023 03:57
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 92.1% and project coverage change: +0.7 🎉

Comparison is base (e402bfa) 58.8% compared to head (3696668) 59.5%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3988     +/-   ##
=======================================
+ Coverage   58.8%   59.5%   +0.7%     
=======================================
  Files        142     145      +3     
  Lines      15996   16125    +129     
=======================================
+ Hits        9410    9603    +193     
+ Misses      5955    5889     -66     
- Partials     631     633      +2     
Impacted Files Coverage Δ
internal/dataplane/parser/translate_grpcroute.go 11.1% <0.0%> (+6.3%) ⬆️
...ternal/dataplane/parser/translators/ingress_atc.go 87.4% <ø> (-1.0%) ⬇️
...rnal/dataplane/parser/translators/httproute_atc.go 98.1% <92.3%> (-0.6%) ⬇️
...rnal/dataplane/parser/translators/grpcroute_atc.go 93.2% <93.2%> (ø)
internal/dataplane/parser/translators/grpcroute.go 96.2% <96.2%> (ø)
internal/dataplane/parser/translators/atc_utils.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@randmonkey randmonkey marked this pull request as ready for review May 11, 2023 07:53
@randmonkey randmonkey force-pushed the feat/translate_grpc_route branch 2 times, most recently from eff674f to 66b4dac Compare May 12, 2023 06:22
@randmonkey randmonkey merged commit 420f02a into main May 15, 2023
25 checks passed
@randmonkey randmonkey deleted the feat/translate_grpc_route branch May 15, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API size/XXL work in progress Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate GRPCRoute to expression based routes
2 participants