Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gwapi): setup controllers dynamically when required CRDs get installed #3996

Merged
merged 4 commits into from
May 16, 2023

changelog entry, comment on enableReferenceGrant

2978bc1
Select commit
Loading
Failed to load commit list.
Merged

feat(gwapi): setup controllers dynamically when required CRDs get installed #3996

changelog entry, comment on enableReferenceGrant
2978bc1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 16, 2023 in 0s

59.4% (-0.5%) compared to 8ce0421

View this Pull Request on Codecov

59.4% (-0.5%) compared to 8ce0421

Details

Codecov Report

Patch coverage: 70.6% and project coverage change: -0.5 ⚠️

Comparison is base (8ce0421) 59.9% compared to head (2978bc1) 59.4%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3996     +/-   ##
=======================================
- Coverage   59.9%   59.4%   -0.5%     
=======================================
  Files        148     149      +1     
  Lines      16290   16399    +109     
=======================================
- Hits        9759    9753      -6     
- Misses      5898    6009    +111     
- Partials     633     637      +4     
Impacted Files Coverage Δ
internal/manager/scheme/scheme.go 22.5% <0.0%> (-2.5%) ⬇️
internal/controllers/crds/dynamic_controller.go 17.4% <17.4%> (ø)
internal/controllers/gateway/gateway_controller.go 12.6% <87.5%> (+1.2%) ⬆️
...ternal/controllers/gateway/httproute_controller.go 48.3% <90.0%> (-9.0%) ⬇️
internal/manager/controllerdef.go 98.8% <100.0%> (+<0.1%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.