chore(tests): switch to EndpointSlices for webhook tests #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3998 +/- ##
=======================================
- Coverage 74.2% 73.5% -0.8%
=======================================
Files 142 142
Lines 15996 15996
=======================================
- Hits 11885 11773 -112
- Misses 3361 3454 +93
- Partials 750 769 +19 ☔ View full report in Codecov by Sentry. |
pmalek
reviewed
May 12, 2023
programmer04
force-pushed
the
fix-flakiness
branch
from
8e944cd
to
7f67da3
Compare
pmalek
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes integration tests flakiness introduced by PR #3980.
Sometimes integration test
TestHTTPRouteValidationWebhookThis change should make this test passes constantly.
Which issue this PR fixes:
Furthermore it's part of the issue #3916 - getting rid of
CoreV1 EndpointsSpecial notes for your reviewer:
It fixes the problem because now tests rely on DiscoveryV1 EndpointSlices instead of old CoreV1 Endpoints. It used to work sometimes because the cluster's control plane mirrors most Endpoints resources to corresponding EndpointSlices as described in docs. When the test failed it means that race condition occurred - the test expected to have EndpointSlices available before they had been created. It explains that only sometimes the test fails.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR