feat(konnect): propagate 429's retry-after header value #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
retry-after-konnect
branch
from
3d1f725
to
5ff9258
Compare
czeslavo
force-pushed
the
retry-after-konnect
branch
2 times, most recently
from
ef5a6e2
to
58e8bae
Compare
pmalek
previously approved these changes
May 15, 2023
czeslavo
force-pushed
the
retry-after-konnect
branch
from
58e8bae
to
9c4f619
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4015 +/- ##
=====================================
Coverage 59.8% 59.8%
=====================================
Files 148 148
Lines 16266 16290 +24
=====================================
+ Hits 9728 9749 +21
- Misses 5903 5905 +2
- Partials 635 636 +1
☔ View full report in Codecov by Sentry. |
pmalek
approved these changes
May 16, 2023
randmonkey
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Makes use of
Retry-AfterHTTP header when 429 is returned from Konnect RG's Admin API.Which issue this PR fixes:
Part of #3959.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR