Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): unify import aliases and introduce forbidigo #4016

Merged
merged 1 commit into from
May 16, 2023

Conversation

programmer04
Copy link
Member

What this PR does / why we need it:

  • unify how k8s.io/* packages are imported (with standardised aliases)
  • introduce forbidgo to prevent using old CoreV1 Endpoints

Which issue this PR fixes:

Introducing and configuring fobidgo is a nice to have for issue #3916.

Special notes for your reviewer:

CI will pass after merging PR #3997 that gets rid of CoreV1 Endpoints

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

pmalek
pmalek previously approved these changes May 16, 2023
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 56.1% and project coverage change: +0.1 🎉

Comparison is base (4fa7cf0) 59.7% compared to head (05b3dbf) 59.8%.

❗ Current head 05b3dbf differs from pull request most recent head 3da08a2. Consider uploading reports for the commit 3da08a2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4016     +/-   ##
=======================================
+ Coverage   59.7%   59.8%   +0.1%     
=======================================
  Files        149     148      -1     
  Lines      16399   16266    -133     
=======================================
- Hits        9793    9731     -62     
+ Misses      5970    5900     -70     
+ Partials     636     635      -1     
Impacted Files Coverage Δ
...ntrollers/configuration/kongadminapi_controller.go 69.8% <ø> (ø)
...nal/controllers/configuration/secret_controller.go 28.1% <ø> (ø)
...trollers/configuration/zz_generated_controllers.go 27.3% <0.0%> (ø)
internal/controllers/gateway/gateway_controller.go 11.3% <0.0%> (-1.3%) ⬇️
...ternal/controllers/gateway/grpcroute_controller.go 8.8% <0.0%> (ø)
...nternal/controllers/gateway/tcproute_controller.go 8.6% <0.0%> (ø)
...nternal/controllers/gateway/tlsroute_controller.go 8.8% <0.0%> (ø)
...nternal/controllers/gateway/udproute_controller.go 8.6% <0.0%> (ø)
internal/controllers/reference/reference.go 10.2% <0.0%> (ø)
internal/manager/config.go 94.5% <ø> (ø)
... and 14 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@programmer04 programmer04 merged commit b53c014 into main May 16, 2023
22 checks passed
@programmer04 programmer04 deleted the fobidigo-ci branch May 16, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants