Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rbac): get rid of rbac permissions for secrets/status #4017

Merged
merged 1 commit into from
May 16, 2023

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented May 16, 2023

What this PR does / why we need it:

This PR remove rbac permissions for secrets/status subresource, because they are redundant. According to docs secrets don't contain this field.

Which issue this PR fixes:

It's been spotted during work on #3997

Special notes for your reviewer:

Issue Kong/charts#795 to covers it in Helm Chart

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek added this to the KIC v2.10.0 milestone May 16, 2023
@programmer04 programmer04 merged commit a98e706 into main May 16, 2023
22 checks passed
@programmer04 programmer04 deleted the get-rid-of-secrets-status branch May 16, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants