feat: Gateway Discovery produce DNS names instead of IP addresses #4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
gateway-discovery-dns-names-instead-of-ips
branch
from
254bf5b
to
7fe7100
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4044 +/- ##
=====================================
Coverage 59.9% 59.9%
=====================================
Files 149 149
Lines 16462 16481 +19
=====================================
+ Hits 9863 9882 +19
- Misses 5971 5972 +1
+ Partials 628 627 -1
☔ View full report in Codecov by Sentry. |
|
E2E (targeted) tests were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5025607446 |
randmonkey
approved these changes
May 22, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This changes the implementation Gateway Discovery in a way that it now produces DNS names instead of IP address of Kong's pods.
There are 2 formats that this implementation can use:
pod-ip-address.service-name.my-namespace.svc- when a Kong'sEndpointSlicethat we're trying to convert into an address (that will be used for sending the configuration) contains an owner reference of typeServicethen we use that reference to build the DNS namepod-ip-address.my-namespace.podwhen thatServiceowner reference is missingRef: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/
Which issue this PR fixes:
Closes: #3934
Special notes for your reviewer:
This will be required for Kong Gateway Operator to use TLS verification.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR