feat(tests): set --max-endpoints-per-slice=2 in K8s Kind clusters used in e2e tests #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E (targeted) tests were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5091614380 |
pmalek
approved these changes
May 26, 2023
|
For ci/run-e2e on GKE image that does not include #4071 (from yesterday was used, thus GKE results are ignored. For Kind everything is 🟢 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Since KIC should work with multiple EndpointSlices, it should be covered with tests too. By default
100endpoints are allowed perEndpointSlicethus havingDeploymentwithServicethat uses multipleEndpointSlices is not feasible in CI tests. This PR configures Kind clusters with--max-endpoints-per-slice 2to make possible to test KIC against Services with multiple EndpointSlices.Next PRs will focus to ensure that test cases actually test it.
Which issue this PR fixes:
This is a part of implementing e2e tests that verifies proper handling of EndpointSlices #4026.
Special notes for your reviewer:
This is the part of implementing strategy proposed in this one too big PR #4084.
Labelled with
ci/run-e2eto be sure, result has to be examined.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR