feat: all-in-one manifests migrations job improvement #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E (targeted) tests were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5135226233 |
czeslavo
changed the title
czeslavo
force-pushed
the
all-in-one-migrations
branch
from
96a5c25
to
b20ddd3
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4116 +/- ##
=======================================
- Coverage 60.4% 55.5% -4.9%
=======================================
Files 150 146 -4
Lines 16745 16603 -142
=======================================
- Hits 10114 9224 -890
- Misses 6000 6861 +861
+ Partials 631 518 -113 ☔ View full report in Codecov by Sentry. |
pmalek
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
kong migrations bootstrapalone works fine when installing a fresh instance of KIC with DB-backed Kong. It doesn't work though when we'd like to upgrade and keep the DB state between the upgrades, because it only bootstraps a fresh database - when there is one already in existence, it just returns.This PR aims to solve this issue by adding additional commands to the migrations job:
kong migrations up && kong migrations finishwhich will make the job detect new migrations that need to be run after the upgrade and finish them.Which issue this PR fixes:
It was discovered when writing E2E tests for #4025.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR