Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect OpenShift version #4211

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Detect OpenShift version #4211

merged 1 commit into from
Jun 30, 2023

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Jun 22, 2023

What this PR does / why we need it:

Adds a draft OpenShift version detection module from telemetry, enables it, and updates some tests for it.

Which issue this PR fixes:

Fix #3149

Special notes for your reviewer:

Relies on Kong/kubernetes-telemetry#168 draft.

Unsure if we want any KIC-level gate before enabling this workflow. We can maybe get a client in the manager setup to check if the chosen namespace exists--if it doesn't, we're presumably not on OpenShift and never will be--but didn't bother for the PoC.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -32.0 ⚠️

Comparison is base (f381c98) 62.8% compared to head (206fe2d) 30.9%.

❗ Current head 206fe2d differs from pull request most recent head 502c300. Consider uploading reports for the commit 502c300 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #4211      +/-   ##
========================================
- Coverage   62.8%   30.9%   -32.0%     
========================================
  Files        154     153       -1     
  Lines      17125   17017     -108     
========================================
- Hits       10759    5259    -5500     
- Misses      5680   11119    +5439     
+ Partials     686     639      -47     

see 111 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pmalek
pmalek previously approved these changes Jun 30, 2023
@rainest
Copy link
Contributor Author

rainest commented Jun 30, 2023

Test updated. Curse you order-sensitive comparison value.

@rainest rainest merged commit 4f933ab into main Jun 30, 2023
27 checks passed
@rainest rainest deleted the feat/detect-os branch June 30, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include OpenShift cluster version in the telemetry
2 participants