-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(konnect): update nodes status only when it actually changes #4324
Conversation
a8b7117
to
fa2cddd
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4324 +/- ##
=======================================
+ Coverage 64.9% 65.1% +0.1%
=======================================
Files 154 154
Lines 17384 17416 +32
=======================================
+ Hits 11297 11339 +42
+ Misses 5367 5356 -11
- Partials 720 721 +1
☔ View full report in Codecov by Sentry. |
fa2cddd
to
3ddedad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Some minor comments to consider
d99b42e
to
0be0a59
Compare
I believe the milestone should be set to v2.11, right? The backport will have it set to v2.10. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.10.x release/2.10.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.10.x
# Create a new branch
git switch --create backport-4324-to-release/2.10.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f861118a88b9e67aa37cd42edda0162d184026e4
# Push it to GitHub
git push --set-upstream origin backport-4324-to-release/2.10.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.10.x Then, create a pull request where the |
What this PR does / why we need it:
Makes sure that:
NodeAgent
calls Konnect APIs only when the config status actually changes (enforce that on both ends of the notification channel - inNodeAgent
and inKongClient
). This was an actual reason for KIC updating nodes every 3s.NodeAgent
calls Konnect APIs only when a set of Gateway clients actually changes (enforce that onClientsManager
side)Also improves debug logging to make it visible when the calls are made.
After this change,
NodeAgent
will call Konnect APIs in the following cases:Which issue this PR fixes:
Fixes #4322.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR