Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(conformance): disable HTTPRouteHeaderMatching #4345

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Jul 13, 2023

What this PR does / why we need it:

#4296 was supposed to fix HTTPRouteHeaderMatching conformance test but is failing consistently, affecting other PRs as well. This PR disables such a test.

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca requested a review from a team as a code owner July 13, 2023 15:56
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ed49854) 65.5% compared to head (12f889b) 65.6%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4345   +/-   ##
=====================================
  Coverage   65.5%   65.6%           
=====================================
  Files        154     154           
  Lines      17722   17722           
=====================================
+ Hits       11618   11633   +15     
+ Misses      5375    5366    -9     
+ Partials     729     723    -6     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mlavacca mlavacca merged commit b633f8f into main Jul 13, 2023
35 checks passed
@mlavacca mlavacca deleted the mlavacca/disable-header-test branch July 13, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants