Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support ResponseHeaderModifier filter #4350

Merged
merged 3 commits into from
Jul 14, 2023
Merged

feat: support ResponseHeaderModifier filter #4350

merged 3 commits into from
Jul 14, 2023
+78 −4

Conversation

rodman10
Copy link
Contributor

What this PR does / why we need it:

This PR support ResponseHeaderModifier Gateway API filter.

Which issue this PR fixes:
Fixes #3683

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@rodman10
Copy link
Contributor Author

Through translating responseHeaderModifier field to response-transform Kong plugin with headers config, the extended ResponseHeaderModifier gateway-api filter is now supported.
Since HTTPRouteFilter in HTTPBackendRef is Implementation-specific support, same as other implemented filter, ResponseHeaderModifier will only support in HTTPRouteRule.
This PR contains following changes:

  • add new helper function for both request and response header modifier filter.
  • complement request header modifier unittest.

@rodman10 rodman10 marked this pull request as ready for review July 14, 2023 02:23
@rodman10 rodman10 requested a review from a team as a code owner July 14, 2023 02:23
@rodman10 rodman10 changed the title Respheader modifier feat: support ResponseHeaderModifier filter Jul 14, 2023
@rodman10 rodman10 mentioned this pull request Jul 14, 2023
Closed
2 tasks
mlavacca
mlavacca approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @rodman10! Thanks for your contribution 🚀

@mlavacca mlavacca merged commit 5c32163 into Kong:main Jul 14, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randmonkey randmonkey randmonkey approved these changes

@mlavacca mlavacca mlavacca approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extended conformance - HTTPResponseHeaderModification
4 participants
@rodman10 @CLAassistant @randmonkey @mlavacca