Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use /status/ready as readiness probe of gateway for gateway discovery #4368

Merged
merged 11 commits into from
Jul 21, 2023

do not use logrus

92ffd58
Select commit
Failed to load commit list.
Merged

feat: use /status/ready as readiness probe of gateway for gateway discovery #4368

do not use logrus
92ffd58
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Jul 21, 2023 in 1s

65.9% (+0.2%) compared to 00cf5d1

View this Pull Request on Codecov

65.9% (+0.2%) compared to 00cf5d1

Details

Codecov Report

Patch coverage: 93.1% and project coverage change: +0.2 🎉

Comparison is base (00cf5d1) 65.7% compared to head (92ffd58) 65.9%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4368     +/-   ##
=======================================
+ Coverage   65.7%   65.9%   +0.2%     
=======================================
  Files        157     158      +1     
  Lines      18159   18274    +115     
=======================================
+ Hits       11939   12052    +113     
- Misses      5481    5484      +3     
+ Partials     739     738      -1     
Impacted Files Coverage Δ
internal/adminapi/client.go 47.0% <0.0%> (-1.5%) ⬇️
internal/manager/run.go 53.2% <50.0%> (+0.1%) ⬆️
internal/clients/readiness.go 89.8% <89.8%> (ø)
internal/adminapi/endpoints.go 84.2% <100.0%> (ø)
internal/clients/manager.go 97.7% <100.0%> (+2.9%) ⬆️
...ntrollers/configuration/kongadminapi_controller.go 62.7% <100.0%> (+0.4%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.