fix(parser) support same-name services across NSes #4375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4375 +/- ##
=====================================
Coverage 66.6% 66.7%
=====================================
Files 158 158
Lines 18563 18571 +8
=====================================
+ Hits 12379 12396 +17
+ Misses 5429 5426 -3
+ Partials 755 749 -6
☔ View full report in Codecov by Sentry. |
rainest
force-pushed
the
fix/multi-namespace-backends
branch
from
a3c2cfd
to
e571956
Compare
pmalek
reviewed
Jul 24, 2023
Correctly build upstreams for multiple backends where multiple services in the backends share the same name in different namespaces. Previously services were indexed by name alone in the rule builder, resulting in one clobbering the other(s).
rainest
force-pushed
the
fix/multi-namespace-backends
branch
from
e571956
to
8ed3d77
Compare
rainest
force-pushed
the
fix/multi-namespace-backends
branch
from
8ed3d77
to
1a217fa
Compare
|
This encountered a flake with TestGatewayWithGatewayClassReconciliation in envtests. Could not replicate, and don't think we have an equivalent of the integration dumps to try and analyze why it happens when it does. |
randmonkey
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Correctly build upstreams for multiple backends where multiple services in the backends share the same name in different namespaces. Previously services were indexed by name alone in the rule builder, resulting in one clobbering the other(s).
Which issue this PR fixes:
Fix #3860
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR