Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Consumer Group can be configured #4387

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Jul 21, 2023

What this PR does / why we need it:

In #4325 Consumer Group CRD and the boilerplate controller has been introduced. This PR continues that effort - applied Consumer Group will be configured in Kong Gateway. Validation webhook, adding Consumers, and scoping Plugins will be introduced in the next PRs.

Which issue this PR fixes:

This is a part of #3728 and closes #4358

Special notes for your reviewer:

The introduced integration test TestConsumerGroup will evolve in the future to cover all features of it e.g. adding Consumers to Consumer Group. Since Consumer Group doesn't do anything useful yet for now check directly in Gateway if it was created. Later it will be replaced with a proper testing scenario.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@programmer04 programmer04 self-assigned this Jul 21, 2023
@programmer04 programmer04 added do not merge let the author merge this, don't merge for them. area/CRD Changes in existing CRDs or introduction of new ones area/feature New feature or request and removed size/L labels Jul 21, 2023
@programmer04 programmer04 added this to the KIC v2.11.0 milestone Jul 21, 2023
@programmer04 programmer04 changed the title Consumergroup configure feat: Consumer Group can be configured Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 39.3% and project coverage change: +4.7% 🎉

Comparison is base (4b4fcab) 61.6% compared to head (ac5cff6) 66.4%.

❗ Current head ac5cff6 differs from pull request most recent head a34634d. Consider uploading reports for the commit a34634d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4387     +/-   ##
=======================================
+ Coverage   61.6%   66.4%   +4.7%     
=======================================
  Files        159     158      -1     
  Lines      18680   18617     -63     
=======================================
+ Hits       11513   12362    +849     
+ Misses      6499    5494   -1005     
- Partials     668     761     +93     
Files Changed Coverage Δ
internal/dataplane/deckgen/generate.go 49.7% <0.0%> (+5.2%) ⬆️
internal/dataplane/kongstate/kongstate.go 66.9% <6.6%> (-2.3%) ⬇️
internal/store/fake_store.go 39.6% <44.4%> (+0.1%) ⬆️
internal/store/store.go 59.3% <59.2%> (+0.8%) ⬆️
internal/dataplane/parser/parser.go 78.9% <100.0%> (+1.7%) ⬆️

... and 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@programmer04 programmer04 force-pushed the consumergroup-configure branch 2 times, most recently from 4104ed5 to e15acc3 Compare July 21, 2023 16:12
@programmer04 programmer04 added work in progress Work In Progress and removed do not merge let the author merge this, don't merge for them. labels Jul 24, 2023
@programmer04 programmer04 force-pushed the consumergroup-configure branch 2 times, most recently from ff994bb to d01d2ae Compare July 26, 2023 16:10
@programmer04 programmer04 removed the work in progress Work In Progress label Jul 26, 2023
@programmer04 programmer04 marked this pull request as ready for review July 26, 2023 16:22
@programmer04 programmer04 requested a review from a team as a code owner July 26, 2023 16:22
@programmer04 programmer04 enabled auto-merge (squash) July 26, 2023 16:23
@programmer04 programmer04 added the do not merge let the author merge this, don't merge for them. label Jul 26, 2023
@programmer04 programmer04 removed the do not merge let the author merge this, don't merge for them. label Jul 27, 2023
@programmer04 programmer04 merged commit 0aef048 into main Jul 27, 2023
30 checks passed
@programmer04 programmer04 deleted the consumergroup-configure branch July 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CRD Changes in existing CRDs or introduction of new ones area/feature New feature or request size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign stable IDs to ConsumerGroups
2 participants