-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Consumer Group can be configured #4387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4387 +/- ##
=======================================
+ Coverage 61.6% 66.4% +4.7%
=======================================
Files 159 158 -1
Lines 18680 18617 -63
=======================================
+ Hits 11513 12362 +849
+ Misses 6499 5494 -1005
- Partials 668 761 +93
☔ View full report in Codecov by Sentry. |
4104ed5
to
e15acc3
Compare
ff994bb
to
d01d2ae
Compare
czeslavo
reviewed
Jul 26, 2023
ac5cff6
to
a34634d
Compare
czeslavo
approved these changes
Jul 27, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CRD
Changes in existing CRDs or introduction of new ones
area/feature
New feature or request
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In #4325 Consumer Group CRD and the boilerplate controller has been introduced. This PR continues that effort - applied Consumer Group will be configured in Kong Gateway. Validation webhook, adding Consumers, and scoping Plugins will be introduced in the next PRs.
Which issue this PR fixes:
This is a part of #3728 and closes #4358
Special notes for your reviewer:
The introduced integration test
TestConsumerGroup
will evolve in the future to cover all features of it e.g. adding Consumers to Consumer Group. Since Consumer Group doesn't do anything useful yet for now check directly in Gateway if it was created. Later it will be replaced with a proper testing scenario.PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR