feat: populate Programmed condition for KongConsumerGroup #4423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
added
area/feature
programmer04
force-pushed
the
kcg-populate-programmed
branch
from
bc9b502
to
7e84cf2
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4423 +/- ##
=======================================
+ Coverage 67.1% 67.8% +0.6%
=======================================
Files 159 159
Lines 18749 18772 +23
=======================================
+ Hits 12598 12738 +140
+ Misses 5386 5266 -120
- Partials 765 768 +3
☔ View full report in Codecov by Sentry. |
czeslavo
reviewed
Jul 28, 2023
programmer04
force-pushed
the
kcg-populate-programmed
branch
2 times, most recently
from
8ec410b
to
bd84369
Compare
|
Can you please add |
programmer04
force-pushed
the
kcg-populate-programmed
branch
from
bd84369
to
a7dd691
Compare
|
Good point @czeslavo, I've enhanced those entries |
czeslavo
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Populates Programmed condition for
KongConsumerGroupand prints an additional columnPROGRAMMEDfor this CRD as introduced in #4425 for others.Which issue this PR fixes:
Part of #3728
Special notes for your reviewer:
Something to discuss - I decided to check in the integration test if the condition is populated correctly because the duration of this check is ~3 seconds, hence it's negligible for an overall length of execution ~2.5%. Unfortunately, it has been written in this verbose way, because stretchr/testify#1391 hasn't been resolved yet.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR