-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consumer group): add validation admission webhook #4437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
added
area/feature
New feature or request
work in progress
Work In Progress
labels
Jul 31, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4437 +/- ##
=======================================
- Coverage 67.6% 65.8% -1.8%
=======================================
Files 160 155 -5
Lines 18742 18670 -72
=======================================
- Hits 12670 12298 -372
- Misses 5309 5654 +345
+ Partials 763 718 -45
☔ View full report in Codecov by Sentry. |
programmer04
force-pushed
the
add-consumergroup-validation
branch
2 times, most recently
from
August 1, 2023 12:17
b642b95
to
83e3890
Compare
programmer04
force-pushed
the
add-consumergroup-validation
branch
from
August 1, 2023 12:19
83e3890
to
4a81184
Compare
pmalek
reviewed
Aug 1, 2023
programmer04
force-pushed
the
add-consumergroup-validation
branch
from
August 1, 2023 12:37
4a81184
to
22e7789
Compare
pmalek
reviewed
Aug 1, 2023
programmer04
force-pushed
the
add-consumergroup-validation
branch
from
August 1, 2023 12:49
22e7789
to
b1e9b3d
Compare
czeslavo
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds validation webhook for consumer groups that work this way
Which issue this PR fixes:
This is part of #3728
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR