Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump dependencies versions in go.mod #4454

Merged
merged 2 commits into from
Aug 4, 2023
Merged

chore(deps): bump dependencies versions in go.mod #4454

merged 2 commits into from
Aug 4, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Aug 4, 2023

What this PR does / why we need it:

Bump some dependencies versions (e.g. those without a semver which are not being bumped by dependabot).

@pmalek pmalek added the dependencies Pull requests that update a dependency file label Aug 4, 2023
@pmalek pmalek added this to the KIC v2.11.0 milestone Aug 4, 2023
@pmalek pmalek self-assigned this Aug 4, 2023
@pmalek pmalek requested a review from a team as a code owner August 4, 2023 10:38
@pmalek pmalek enabled auto-merge (squash) August 4, 2023 10:39
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.1% ⚠️

Comparison is base (7e567cc) 67.5% compared to head (a037a5b) 67.4%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4454     +/-   ##
=======================================
- Coverage   67.5%   67.4%   -0.1%     
=======================================
  Files        160     160             
  Lines      18804   18804             
=======================================
- Hits       12699   12686     -13     
- Misses      5343    5350      +7     
- Partials     762     768      +6     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@programmer04 programmer04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more places with redundant map[string]string{} for annotations just grep for it 😉
(it's the only use-case), e.g. missed file internal/dataplane/parser/translate_utils_test.go or test/integration/udproute_test.go

@pmalek
Copy link
Member Author

pmalek commented Aug 4, 2023

There are more places with redundant map[string]string{} for annotations just grep for it 😉 (it's the only use-case), e.g. missed file internal/dataplane/parser/translate_utils_test.go or test/integration/udproute_test.go

👍 Didn't change those because the tests didn't fail :). Let's see if they pass now 🤞

@programmer04 programmer04 self-requested a review August 4, 2023 13:10
Copy link
Member

@programmer04 programmer04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@pmalek pmalek merged commit bceedda into main Aug 4, 2023
39 checks passed
@pmalek pmalek deleted the bump-deps branch August 4, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants