test(e2e): move environment used in e2e to testenv package

[randmonkey]

What this PR does / why we need it:

move definition of all environment variable required in e2e tests in testenv package. Also adds some helper functions to the package.

Which issue this PR fixes:

fixes #4593
Special notes for your reviewer:

TODO:

• update env variables/inputs in .github/workflows (how to update the outputs for image of docker build to put them separately in targeted e2e tests?)
• update document TESTING.md

REVIEW: the env vars to specify images in e2e tests are changed, from a single *_IMAGE_OVERRIDE to *_IMAGE and *_TAG. Should this change happen?

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

• the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

[pmalek]

REVIEW: the env vars to specify images in e2e tests are changed, from a single *_IMAGE_OVERRIDE to *_IMAGE and *_TAG. Should this change happen?

I'd suggest that we do this change only if the can make it consistent with e.g. env variables used for Kong images

[programmer04]

For env variables for the Kong image please ensure that passing the image digest is possible too e.g.

kong:3.4.0-ubuntu@sha256:fdfe2b3097e19964e2293ddc218ac714ab630483be0f835f4f5f52ca1ee9a7cb 

it is useful when for instance when you report a bug to Gateway and want to ensure that everybody talks about exactly the same artifact

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (82dbd35) 78.0% compared to head (c3d6bd9) 78.0%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #4607   +/-   ##
=====================================
  Coverage   78.0%   78.0%           
=====================================
  Files        163     163           
  Lines      18531   18546   +15     
=====================================
+ Hits       14458   14477   +19     
- Misses      3264    3265    +1     
+ Partials     809     804    -5     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[team-k8s-bot]

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6085026268

[randmonkey]

For env variables for the Kong image please ensure that passing the image digest is possible too e.g.

kong:3.4.0-ubuntu@sha256:fdfe2b3097e19964e2293ddc218ac714ab630483be0f835f4f5f52ca1ee9a7cb 

it is useful when for instance when you report a bug to Gateway and want to ensure that everybody talks about exactly the same artifact

Actually we can use the name@digest format like kong@sha256:fdfe2b3097e19964e2293ddc218ac714ab630483be0f835f4f5f52ca1ee9a7cb to specify an image with given SHA digest. So I decide not to support parsing kong version from tag@digest format, but support providing Kong version via env TEST_KONG_EFFECTIVE_VERSION.

[team-k8s-bot]

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6218969564

[pmalek]

@randmonkey The e2e tests failed :(

[randmonkey]

@randmonkey The e2e tests failed :(

Digged a while in workflow files and logs of the e2e runs and found that I did not update all appearances of inputs.kong-image (

[team-k8s-bot]

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6225645924

[team-k8s-bot]

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6490928774

[team-k8s-bot]

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6493972188