Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated KongIngress functionality #4760

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Sep 29, 2023

What this PR does / why we need it:

Stops respecting deprecated KongIngress Proxy and Route fields and aligns tests to use annotations in favor of KongIngress.

Which issue this PR fixes:

Closes #3018 and #4740.

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo self-assigned this Sep 29, 2023
@czeslavo czeslavo added the area/CRD Changes in existing CRDs or introduction of new ones label Sep 29, 2023
@czeslavo czeslavo added this to the KIC v3.0.0 milestone Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (edfd7e2) 67.5% compared to head (76981cd) 77.7%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #4760      +/-   ##
========================================
+ Coverage   67.5%   77.7%   +10.1%     
========================================
  Files        163     163              
  Lines      18667   18526     -141     
========================================
+ Hits       12609   14403    +1794     
+ Misses      5323    3315    -2008     
- Partials     735     808      +73     
Files Coverage Δ
internal/admission/handler.go 61.2% <100.0%> (+28.4%) ⬆️
internal/dataplane/kongstate/kongstate.go 79.1% <100.0%> (+3.8%) ⬆️
internal/dataplane/kongstate/route.go 97.5% <100.0%> (+6.5%) ⬆️
internal/dataplane/kongstate/service.go 68.4% <100.0%> (+21.6%) ⬆️
internal/dataplane/kongstate/util.go 89.0% <ø> (-0.3%) ⬇️

... and 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo marked this pull request as ready for review September 29, 2023 14:03
@czeslavo czeslavo requested a review from a team as a code owner September 29, 2023 14:03
@czeslavo czeslavo merged commit be62bf7 into main Oct 2, 2023
33 checks passed
@czeslavo czeslavo deleted the drop-deprecated-kongingress branch October 2, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CRD Changes in existing CRDs or introduction of new ones size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable support for deprecated KongIngress fields
2 participants