-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(telemetry) add Kong router flavor #4762
Conversation
a193efa
to
05d7094
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4762 +/- ##
=======================================
- Coverage 77.8% 77.6% -0.2%
=======================================
Files 163 163
Lines 18526 18532 +6
=======================================
- Hits 14416 14399 -17
- Misses 3305 3322 +17
- Partials 805 811 +6
☔ View full report in Codecov by Sentry. |
05d7094
to
bb7c7ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's not exactly what Konnect expected from us (it was about the UI side requiring some way to tell if a route we populate in Konnect is expression or traditional and we concluded it can be easily derived from the route itself).
Probably having telemetry for this won't hurt us and can be useful in the future. Worth to note though that we already have telemetry for tracking the feature gates so the ExpressionsRoutes
feature is kinda tracked even without this.
bb7c7ca
to
65e387c
Compare
Remove a log that would emit during an expected test shutdown condition. This suggested that condition was the problem, rather than other problems earlier.
65e387c
to
aaa811a
Compare
I expect we'll remove the feature flag (GA support for controller-managed expression routes) before the gateway removes traditional (if it does at all), so it'll be useful later. Also removed a rather unhelpful log. Failures due to the (unfortunately very touchy) expected value not matching looked like:
Between not having a message on the Eventually and empty reports apparently being normal (not sure why, but they do show up) at the end of the test, I was very confused searching for why the changes here made part of the static report "disappear". If we break it again, we'll now see:
|
What this PR does / why we need it:
Includes the router flavor in reports.
Special notes for your reviewer:
Tests normally can't run telemetry against a real instance, so an example with that flipped in
KONG_TEST_EXPRESSION_ROUTES=true KONG_TEST_CLUSTER=kind:kind GOFLAGS="-tags=integration_tests" dlv test ./test/integration
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR