chore: add kongintegration test flavor and cover UpdateStrategyInMemory as a reference #4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
narrow-integration-test
branch
2 times, most recently
from
6bf5b6c
to
5519984
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4802 +/- ##
=======================================
- Coverage 78.1% 78.0% -0.1%
=======================================
Files 163 163
Lines 18544 18537 -7
=======================================
- Hits 14486 14463 -23
- Misses 3255 3267 +12
- Partials 803 807 +4 ☔ View full report in Codecov by Sentry. |
pmalek
reviewed
Oct 10, 2023
czeslavo
force-pushed
the
narrow-integration-test
branch
10 times, most recently
from
2ffc16a
to
7abdf74
Compare
|
Target |
czeslavo
force-pushed
the
narrow-integration-test
branch
2 times, most recently
from
5cf1c23
to
4417c23
Compare
pmalek
reviewed
Oct 11, 2023
|
Since the contents of this PR have changed (to introduce a new kind of tests) please change the PR title to reflect this fact. |
czeslavo
changed the title
3 tasks
pmalek
previously approved these changes
Oct 11, 2023
czeslavo
force-pushed
the
narrow-integration-test
branch
from
2c6dded
to
9635e97
Compare
Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
czeslavo
force-pushed
the
narrow-integration-test
branch
from
9635e97
to
a2b85e4
Compare
czeslavo
force-pushed
the
narrow-integration-test
branch
from
a2b85e4
to
a3327a2
Compare
pmalek
reviewed
Oct 12, 2023
pmalek
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds an integration test for
sendconfig.UpdateStrategyInMemoryto verify we correctly integrate with Kong's flattened errors.It also creates a separate "kongintegration" test flavor (name to be discussed, I'm open to suggestions). I think we could benefit from having more coverage in this kind of tests instead of always adding a regular integration or E2E case. They all could be independent and run in parallel with no problems. We could test various Kong settings in them as every test spawns its own Kong instance. Their only dependency is to have a running docker daemon.
Which issue this PR fixes:
Follow up of #4790.