Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump gateway API to 1.0.0-rc1 #4893

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Oct 19, 2023

What this PR does / why we need it:

bump gateway API to 1.0.0-rc1:

  • use identifiers in gateway/v1 instead of gateway/v1beta1 if available
  • Use GatewayV1() client to do CRUD on Gateways, GatewayClasses and HTTPRoutes
  • Skip the failing conformance tests added in 1.0.0-rc1

Which issue this PR fixes:

fixes #4879

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner October 19, 2023 07:34
@randmonkey randmonkey marked this pull request as draft October 19, 2023 07:34
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (a29fa09) 77.7% compared to head (021e30c) 77.6%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4893     +/-   ##
=======================================
- Coverage   77.7%   77.6%   -0.1%     
=======================================
  Files        165     165             
  Lines      18457   18460      +3     
=======================================
- Hits       14346   14338      -8     
- Misses      3288    3297      +9     
- Partials     823     825      +2     
Files Coverage Δ
internal/admission/handler.go 59.5% <100.0%> (ø)
internal/controllers/gateway/gateway_controller.go 71.8% <100.0%> (+0.7%) ⬆️
internal/controllers/gateway/gateway_utils.go 85.2% <100.0%> (+0.5%) ⬆️
...nal/controllers/gateway/gatewayclass_controller.go 79.2% <100.0%> (ø)
...ternal/controllers/gateway/httproute_controller.go 76.7% <100.0%> (-0.3%) ⬇️
internal/manager/controllerdef.go 99.4% <100.0%> (ø)
internal/store/store.go 70.6% <100.0%> (ø)
internal/util/builder/routegroupkind.go 100.0% <100.0%> (ø)
internal/dataplane/parser/translate_tlsroute.go 56.3% <0.0%> (ø)
internal/controllers/gateway/route_utils.go 85.9% <60.0%> (-0.2%) ⬇️
... and 2 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randmonkey randmonkey force-pushed the chore/bump_gateway_api_1_0_rc1 branch from 755d230 to d2fe620 Compare October 20, 2023 06:36
@randmonkey randmonkey added this to the KIC v3.0.0 milestone Oct 20, 2023
@randmonkey randmonkey self-assigned this Oct 20, 2023
@randmonkey randmonkey marked this pull request as ready for review October 20, 2023 07:56
@randmonkey randmonkey added the area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API label Oct 20, 2023
test/e2e/features_test.go Show resolved Hide resolved
@pmalek pmalek merged commit 334ea35 into main Oct 20, 2023
35 checks passed
@pmalek pmalek deleted the chore/bump_gateway_api_1_0_rc1 branch October 20, 2023 09:41
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6589010198

rainest pushed a commit that referenced this pull request Oct 24, 2023
* chore: bump gateway API to 1.0.0-rc1

* add type meta and update golden tests

* fix annotation of gateway

* replace gatewayv1beta1 with gatewayv1 if possible and skip failing conformance tests

* add gatewayv1beta1 GVR for validation

* add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Gateway to v1.0.0-rc1
3 participants