Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change container UID and GID #4911

Merged
merged 2 commits into from
Oct 23, 2023
Merged

chore: change container UID and GID #4911

merged 2 commits into from
Oct 23, 2023

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Oct 19, 2023

What this PR does / why we need it:

Changes the container UID and GID from 65532 to 1000.

Which issue this PR fixes:

Part of #4102.

Special notes for your reviewer:

See Kong/charts#909

Running E2E to build a test image on the offchance this somehow breaks something, but it really shouldn't.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR~

@rainest rainest added the ci/run-e2e Trigger e2e test run from PR label Oct 19, 2023
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6581538249

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f7dc01) 77.7% compared to head (641d4e5) 77.8%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4911   +/-   ##
=====================================
  Coverage   77.7%   77.8%           
=====================================
  Files        165     165           
  Lines      18477   18477           
=====================================
+ Hits       14371   14384   +13     
+ Misses      3282    3275    -7     
+ Partials     824     818    -6     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rainest rainest marked this pull request as ready for review October 20, 2023 18:30
@rainest rainest requested a review from a team as a code owner October 20, 2023 18:30
@rainest rainest enabled auto-merge (squash) October 20, 2023 18:30
@rainest rainest merged commit cda824c into main Oct 23, 2023
46 checks passed
@rainest rainest deleted the chore/docker-user branch October 23, 2023 08:14
rainest added a commit that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants