chore: exclude admin API comms from mesh #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4942 +/- ##
=====================================
Coverage 77.7% 77.8%
=====================================
Files 165 165
Lines 18480 18480
=====================================
+ Hits 14371 14389 +18
+ Misses 3287 3272 -15
+ Partials 822 819 -3 ☔ View full report in Codecov by Sentry. |
|
Don't want to block it, but out of curiosity: why not allow setting comms with the Admin API to happen with plain HTTP so that Mesh users can use it if needed? |
randmonkey
approved these changes
Oct 24, 2023
1 task
rainest
added a commit
that referenced
this pull request
Oct 24, 2023
* chore: exclude admin API comms from mesh * chore: make manifests * chore: add changelog entry
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Excludes controller->admin API comms from meshes.
Which issue this PR fixes:
Part of #4698
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR