Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update features gates for v3, remove Gateway feature gate #4968

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 25, 2023

What this PR does / why we need it:

This PR:

Special notes for your reviewer:

We do not have CLI flags for enabling/disabling Gateway API controllers. We only did that with the feature flags up until now hence this PR flips the enable criteria on those controllers to true, i.e. always enabled.

Do we want to introduce those?

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek added this to the KIC v3.0.0 milestone Oct 25, 2023
@pmalek pmalek self-assigned this Oct 25, 2023
@pmalek pmalek requested a review from a team as a code owner October 25, 2023 11:34
@pmalek pmalek added the area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7da78ac) 77.6% compared to head (2d5b6be) 77.7%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4968   +/-   ##
=====================================
  Coverage   77.6%   77.7%           
=====================================
  Files        167     167           
  Lines      18708   18707    -1     
=====================================
+ Hits       14529   14540   +11     
+ Misses      3345    3337    -8     
+ Partials     834     830    -4     
Files Coverage Δ
internal/manager/controllerdef.go 99.4% <100.0%> (ø)
internal/manager/featuregates/feature_gates.go 100.0% <ø> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek
Copy link
Member Author

pmalek commented Oct 25, 2023

@programmer04 Let's introduce the CLI flags first and adjust the test code first #4971. Then we can clean up the feature flags here.

randmonkey
randmonkey previously approved these changes Oct 26, 2023
@pmalek pmalek merged commit 1351004 into main Oct 26, 2023
35 checks passed
@pmalek pmalek deleted the v3.0-update-feature-gates branch October 26, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. blocked size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants