Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add KongUpstreamPolicy controller #4969

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Oct 25, 2023

What this PR does / why we need it:

Adds KongUpstreamPolicy controller along with a CLI flag allowing disabling it. Extends stores (prod/fake) to handle the new type. Exposes GetKongUpstreamPolicy from store.Store that will be needed in Parser.

It also moves CacheStores implementation from store.go to a separate cache_stores.go file for better segregation.

Which issue this PR fixes:

Closes #4930.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (0a4845a) 77.7% compared to head (26c500c) 77.5%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4969     +/-   ##
=======================================
- Coverage   77.7%   77.5%   -0.3%     
=======================================
  Files        166     167      +1     
  Lines      18624   18708     +84     
=======================================
+ Hits       14476   14500     +24     
- Misses      3315    3368     +53     
- Partials     833     840      +7     
Files Coverage Δ
internal/manager/config.go 93.1% <100.0%> (+<0.1%) ⬆️
internal/manager/controllerdef.go 99.4% <100.0%> (+<0.1%) ⬆️
internal/store/fake_store.go 39.2% <57.1%> (+0.5%) ⬆️
internal/store/store.go 70.3% <70.0%> (-0.4%) ⬇️
...trollers/configuration/zz_generated_controllers.go 47.1% <20.4%> (-1.2%) ⬇️
internal/store/cache_stores.go 72.4% <72.4%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo force-pushed the feat/kongupstreampolicy-controller branch from 6372234 to 2f1c410 Compare October 25, 2023 12:59
@czeslavo czeslavo self-assigned this Oct 25, 2023
@czeslavo czeslavo added the area/feature New feature or request label Oct 25, 2023
@czeslavo czeslavo added this to the KIC v3.0.0 milestone Oct 25, 2023
@czeslavo czeslavo force-pushed the feat/kongupstreampolicy-controller branch from 2f1c410 to 92ed13a Compare October 25, 2023 13:25
@czeslavo czeslavo marked this pull request as ready for review October 25, 2023 13:47
@czeslavo czeslavo requested a review from a team as a code owner October 25, 2023 13:47
@czeslavo czeslavo force-pushed the feat/kongupstreampolicy-controller branch from 92ed13a to 50e7933 Compare October 25, 2023 14:39
pmalek
pmalek previously approved these changes Oct 25, 2023
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@czeslavo czeslavo merged commit 9f3adb6 into main Oct 26, 2023
35 checks passed
@czeslavo czeslavo deleted the feat/kongupstreampolicy-controller branch October 26, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement KongUpstreamPolicy controller basic functionality
3 participants