-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add KongUpstreamPolicy controller #4969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4969 +/- ##
=======================================
- Coverage 77.7% 77.5% -0.3%
=======================================
Files 166 167 +1
Lines 18624 18708 +84
=======================================
+ Hits 14476 14500 +24
- Misses 3315 3368 +53
- Partials 833 840 +7
☔ View full report in Codecov by Sentry. |
czeslavo
force-pushed
the
feat/kongupstreampolicy-controller
branch
from
October 25, 2023 12:59
6372234
to
2f1c410
Compare
czeslavo
force-pushed
the
feat/kongupstreampolicy-controller
branch
from
October 25, 2023 13:25
2f1c410
to
92ed13a
Compare
czeslavo
force-pushed
the
feat/kongupstreampolicy-controller
branch
from
October 25, 2023 14:39
92ed13a
to
50e7933
Compare
pmalek
previously approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
randmonkey
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
KongUpstreamPolicy
controller along with a CLI flag allowing disabling it. Extends stores (prod/fake) to handle the new type. ExposesGetKongUpstreamPolicy
fromstore.Store
that will be needed inParser
.It also moves
CacheStores
implementation fromstore.go
to a separatecache_stores.go
file for better segregation.Which issue this PR fixes:
Closes #4930.