feat: allow setting hashOn.input in KongUpstreamPolicy #4979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4979 +/- ##
=======================================
- Coverage 77.6% 75.2% -2.5%
=======================================
Files 167 167
Lines 18708 18710 +2
=======================================
- Hits 14532 14080 -452
- Misses 3345 3790 +445
- Partials 831 840 +9
☔ View full report in Codecov by Sentry. |
pmalek
reviewed
Oct 26, 2023
pmalek
previously approved these changes
Oct 26, 2023
czeslavo
force-pushed
the
feat/kongupstreampolicy-hash-input
branch
2 times, most recently
from
3a41a56
to
5fd8082
Compare
|
@pmalek PTAL again, I only backed off from naming changes that I didn't intend to include in this PR. |
czeslavo
force-pushed
the
feat/kongupstreampolicy-hash-input
branch
from
5fd8082
to
72929b2
Compare
pmalek
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows setting
hashOn(Fallback).inputto use one of predefined consistent hashing algorithm inputs (ip,consumer, andpath). I overlooked that in the initial CRD definition.Also adds validation rules that ensure
hashOn(Fallback)can only be set whenalgorithmis set toconsistent-hashing.Which issue this PR fixes:
Part of #3174.